[18Cuba] Par minors with concession exchange#12383
Open
chrstas wants to merge 7 commits intotobymao:masterfrom
Open
[18Cuba] Par minors with concession exchange#12383chrstas wants to merge 7 commits intotobymao:masterfrom
chrstas wants to merge 7 commits intotobymao:masterfrom
Conversation
ollybh
reviewed
Feb 9, 2026
Contributor
Author
|
Did additional tests for cases with players with low cash but concession. To my understanding it should be covered now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements 18Cuba-specific logic for parring minor corporations via concessions. Overrides process_par to handle minors differently: sets the corporation’s par, exchanges a concession for the minor’s starting shares, applies any exchange discounts, updates player ownership, closes the concession if needed, and tracks the action. Also adjusts share-buying rules to prevent minors from selling additional shares after floating.
Before clicking "Create"
masterAdd thepinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeImplementation Notes
Explanation of Change
Screenshots
Any Assumptions / Hacks