Skip to content

[18Cuba] Par minors with concession exchange#12383

Open
chrstas wants to merge 7 commits intotobymao:masterfrom
chrstas:18Cuba-Par-Minor-with-Concession
Open

[18Cuba] Par minors with concession exchange#12383
chrstas wants to merge 7 commits intotobymao:masterfrom
chrstas:18Cuba-Par-Minor-with-Concession

Conversation

@chrstas
Copy link
Contributor

@chrstas chrstas commented Feb 8, 2026

Implements 18Cuba-specific logic for parring minor corporations via concessions. Overrides process_par to handle minors differently: sets the corporation’s par, exchanges a concession for the minor’s starting shares, applies any exchange discounts, updates player ownership, closes the concession if needed, and tracks the action. Also adjusts share-buying rules to prevent minors from selling additional shares after floating.

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

  • Variable name changed to meaningful name in simple_draft (pending reveiwer comment from last PR)
  • Entities consistently completed with types

Explanation of Change

Screenshots

Any Assumptions / Hacks

@ollybh ollybh added new games Issues relating to games that are not yet alpha test level 18Cuba labels Feb 9, 2026
@chrstas chrstas requested a review from ollybh February 10, 2026 17:35
@chrstas
Copy link
Contributor Author

chrstas commented Feb 11, 2026

Did additional tests for cases with players with low cash but concession. To my understanding it should be covered now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

18Cuba new games Issues relating to games that are not yet alpha test level

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants