fix(trino): mark as supporting ...EXCEPT ALL
#6616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for `SELECT * FROM t1 INTERSECT/EXCEPT ALL SELECT * FROM t2` Trino inherits the dialect from Presto. Presto doesn't support the `ALL` modifier, but trino does, see trinodb/trino#5890 We ran into this in ibis, where we are indeed able to compile and successfully execute the ALL modifier, but as soon as [we turned on sqlglot errors](ibis-project/ibis#11772), we then started getting spurious sqlglot errors: https://github.com/ibis-project/ibis/actions/runs/19549750869/job/55977864377?pr=11772
georgesittas
approved these changes
Dec 22, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Let's add a test for this.
Collaborator
|
Will take this to the finish line, thank you @NickCrews! |
georgesittas
pushed a commit
that referenced
this pull request
Dec 24, 2025
This is for `SELECT * FROM t1 INTERSECT/EXCEPT ALL SELECT * FROM t2` Trino inherits the dialect from Presto. Presto doesn't support the `ALL` modifier, but trino does, see trinodb/trino#5890 We ran into this in ibis, where we are indeed able to compile and successfully execute the ALL modifier, but as soon as [we turned on sqlglot errors](ibis-project/ibis#11772), we then started getting spurious sqlglot errors: https://github.com/ibis-project/ibis/actions/runs/19549750869/job/55977864377?pr=11772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for
SELECT * FROM t1 INTERSECT/EXCEPT ALL SELECT * FROM t2Trino inherits the dialect from Presto. Presto doesn't support the
ALLmodifier, but trino does, see trinodb/trino#5890We ran into this in ibis, where we are indeed able to compile and successfully execute the ALL modifier, but as soon as we turned on sqlglot errors, we then started getting spurious sqlglot errors: https://github.com/ibis-project/ibis/actions/runs/19549750869/job/55977864377?pr=11772