Chore(snowflake): Adding type annotation tests for Snowflake's STDDEV / STDDEV_SAMP, STDDEV_POP #6641
+33
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EV → STDDEV_SAMP, window function arg_types, and corresponding tests.
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 2170 total, 1607 passed (pass rate: 74.1%), sqlglot version: sqlglot:feature/annotatetype-stddev: 2170 total, 1607 passed (pass rate: 74.1%), sqlglot version: Difference: No change |
VaggelisD
approved these changes
Dec 30, 2025
Collaborator
VaggelisD
left a comment
VaggelisD
left a comment
There was a problem hiding this comment.
Nice & easy, just one comment to consider, feel free to merge afterwards:
Collaborator
|
This PR is not breaking given that the type annotations exist |
VaggelisD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation:
https://docs.snowflake.com/en/sql-reference/functions/stddev
https://docs.snowflake.com/en/sql-reference/functions/stddev_pop