Skip to content

Chore(snowflake): Adding type annotation tests for Snowflake's STDDEV / STDDEV_SAMP, STDDEV_POP #6641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fivetran-kwoodbeck merged 5 commits into from
Dec 30, 2025
+33 −0
Merged

Chore(snowflake): Adding type annotation tests for Snowflake's STDDEV / STDDEV_SAMP, STDDEV_POP #6641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a9e45c1
Add STDDEV/STDDEV_POP/STDDEV_SAMP support with Snowflake mapping STDD…
fivetran-kwoodbeck Dec 24, 2025
8337b85
added partition tests
fivetran-kwoodbeck Dec 29, 2025
a2a27d7
fixed arguments
fivetran-kwoodbeck Dec 29, 2025
2de8748
removed redundant definition
fivetran-kwoodbeck Dec 30, 2025
eb2c431
made STDDEV and STDDEV_SAMP parse as the same
fivetran-kwoodbeck Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sqlglot/dialects/snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,7 @@ class Parser(parser.Parser):
"SHA2_BINARY": exp.SHA2Digest.from_arg_list,
"SHA2_HEX": exp.SHA2.from_arg_list,
"SQUARE": lambda args: exp.Pow(this=seq_get(args, 0), expression=exp.Literal.number(2)),
"STDDEV_SAMP": exp.Stddev.from_arg_list,
"STRTOK": _build_strtok,
"SYSDATE": lambda args: exp.CurrentTimestamp(this=seq_get(args, 0), sysdate=True),
"TABLE": lambda args: exp.TableFromRows(this=seq_get(args, 0)),
Expand Down
8 changes: 8 additions & 0 deletions tests/dialects/test_snowflake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,14 @@ def test_snowflake(self):
self.validate_identity("WEEKOFYEAR(tstamp)", "WEEK(tstamp)")
self.validate_identity("SELECT QUARTER(CURRENT_TIMESTAMP())")
self.validate_identity("SELECT SUM(amount) FROM mytable GROUP BY ALL")
self.validate_identity("SELECT STDDEV(x)")
self.validate_identity("SELECT STDDEV(x) OVER (PARTITION BY 1)")
self.validate_identity("SELECT STDDEV_POP(x)")
self.validate_identity("SELECT STDDEV_POP(x) OVER (PARTITION BY 1)")
self.validate_identity("SELECT STDDEV_SAMP(x)", "SELECT STDDEV(x)")
self.validate_identity(
"SELECT STDDEV_SAMP(x) OVER (PARTITION BY 1)", "SELECT STDDEV(x) OVER (PARTITION BY 1)"
)
self.validate_identity("WITH x AS (SELECT 1 AS foo) SELECT foo FROM IDENTIFIER('x')")
self.validate_identity("WITH x AS (SELECT 1 AS foo) SELECT IDENTIFIER('foo') FROM x")
self.validate_identity("INITCAP('iqamqinterestedqinqthisqtopic', 'q')")
Expand Down
24 changes: 24 additions & 0 deletions tests/fixtures/optimizer/annotate_functions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4092,6 +4092,30 @@ BOOLEAN;
SEARCH_IP(col, '192.168.0.0');
BOOLEAN;

# dialect: snowflake
STDDEV(tbl.double_col);
DOUBLE;

# dialect: snowflake
STDDEV(tbl.double_col) OVER (PARTITION BY 1);
DOUBLE;

# dialect: snowflake
STDDEV_POP(tbl.double_col);
DOUBLE;

# dialect: snowflake
STDDEV_POP(tbl.double_col) OVER (PARTITION BY 1);
DOUBLE;

# dialect: snowflake
STDDEV_SAMP(tbl.double_col);
DOUBLE;

# dialect: snowflake
STDDEV_SAMP(tbl.double_col) OVER (PARTITION BY 1);
DOUBLE;

# dialect: snowflake
STRTOK_TO_ARRAY('a,b,c', ',');
ARRAY;
Expand Down