-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(optimizer)!: qualify functions with default columns and tables as column references #6373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
reviewed
Nov 20, 2025
71aa367 to
e8994a8
Compare
46bdab7 to
cd483eb
Compare
VaggelisD
reviewed
Nov 26, 2025
georgesittas
approved these changes
Nov 26, 2025
Collaborator
georgesittas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @geooo109! This is breaking.
cd483eb to
949b9c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6358
This PR fixes the qualification of
GENERATE_SERIESand table as column.GENERATE_SERIES
In postgres
GENERATE_SERIEScreates a columngenerate_series, thus in order to safely qualify this we have the two following cases:generate_seriescolumn:Table projection
postgres supports:
The type of
tisrecord, which is an abstract type. We treat this case as the bigquerry table-column reference.