chore(exasol): transformed rank function, ignoring parameters #6408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What motivated this PR?
Exasol doesn't support passing parameters to the
RANKwhich is supported by some dialect such as spark and databricks.How is the existing logic in main incorrect?
For example when transpiling from databricks or spark to exasol
SELECT a, b, rank(b) OVER (ORDER BY b) FROM (VALUES ('A1', 2), ('A1', 1), ('A2', 3), ('A1', 1)) AS tab(a, b)This would fail in exasol because passing parameters to rank is not supported.How does the PR address the aforementioned issues?
The PR ignores the parameter passed to the
RANKfunction.Provide documentation for the SQL functions involved in the implementation & explain whether semantics change / are preserved
The links to documentation - https://docs.exasol.com/db/latest/sql_references/functions/alphabeticallistfunctions/rank.htm. There are no semantics changes in the generator only the parameter is ignored