fix(postgres)!: move postgres range parsers to global level #6591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaggelisD
reviewed
Dec 18, 2025
Collaborator
|
Why are we moving these parsers to base? I think Toby's comment was about ensuring the generators for these expressions live in the base class instead of postgres to avoid failing @ gen time when the dialect is not postgres. |
Contributor
Author
got your point! will update soon. |
Collaborator
|
We discussed offline that this PR is fine, SQLGlot's base dialect should always be able to parse an AST. |
Contributor
Author
I need to round trip the @ only now, right? |
VaggelisD
reviewed
Dec 19, 2025
VaggelisD
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the feedback from @tobymao in PR #6545 regarding the global scope of postgres range parsers.