Skip to content

fix(spark, databricks): make_interval week #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
georgesittas merged 1 commit into from
Dec 22, 2025
Merged

fix(spark, databricks): make_interval week #6612

georgesittas merged 1 commit into from
Dec 22, 2025

Conversation

@AbhishekASLK
Copy link
Contributor

@AbhishekASLK AbhishekASLK commented Dec 21, 2025 

SELECT make_interval(100,11,12,13,14,14,15)
class MakeInterval(Func):
    arg_types = {
        "year": False,
        "month": False,
        "week": False,
        "day": False,
        "hour": False,
        "minute": False,
        "second": False,
    }

Databricks
Spark

VaggelisD
VaggelisD approved these changes Dec 22, 2025
View reviewed changes
Copy link
Collaborator

@VaggelisD VaggelisD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One comment:

sqlglot/dialects/bigquery.py
expr = exp.MakeInterval()

for arg_key in expr.arg_types:
for arg_key in ["year", "month", "day", "hour", "minute", "second"]:
Copy link
Collaborator

@VaggelisD VaggelisD Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever an array/set exceeds 3 elements we tend to extract them out of the function e.g check out bigquery.py::DQUOTES_ESCAPING_JSON_FUNCTIONS

Copy link
Contributor Author

@AbhishekASLK AbhishekASLK Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll do that.

@georgesittas
Copy link
Collaborator

georgesittas commented Dec 22, 2025

I'll get this to the finish line.

@georgesittas georgesittas merged commit aeb68b2 into tobymao:main Dec 22, 2025
9 checks passed
georgesittas pushed a commit that referenced this pull request Dec 22, 2025
@AbhishekASLK @georgesittas
Fix(spark): make_interval week (#6612)
c0b3e5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VaggelisD VaggelisD VaggelisD approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AbhishekASLK @georgesittas @VaggelisD