fix(oracle)!: interval expressions #6648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaggelisD
reviewed
Jan 5, 2026
Collaborator
VaggelisD
left a comment
VaggelisD
left a comment
There was a problem hiding this comment.
Hey @AbhishekASLK, thanks once again for the PR, leaving a few comments:
georgesittas
reviewed
Jan 7, 2026
Comment on lines
+290
to
+295
| if unit and self._match_text_seq("TO"): | ||
| to_unit = self._parse_function() or self._parse_var(any_token=True, upper=True) | ||
|
|
||
| if to_unit: | ||
| unit = exp.IntervalSpan(this=unit, expression=to_unit) | ||
| return self.expression(exp.Interval, this=this, unit=unit) |
Collaborator
There was a problem hiding this comment.
Feels like we're repeating existing parts of _parse_interval? Is that the case? Any chances for consolidation / clean up here?
Contributor
Author
There was a problem hiding this comment.
I see the similarity, but I'm struggling to find a clean way to merge the logic 🙂
VaggelisD
reviewed
Jan 9, 2026
Collaborator
|
Hey @AbhishekASLK, appreciate the PR, I'll merge this and see if there's anything to simplify. |
Contributor
Author
Thanks! I’ll look out for your changes, happy to learn from them. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where
oracleinterval expressions failed to parse.Documentation