Skip to content

feat(snowflake)!: Type annotation for ARRAY_REMOVE function#6653

Merged
VaggelisD merged 1 commit intomainfrom
mlee/annotate-array_remove
Jan 5, 2026
Merged

feat(snowflake)!: Type annotation for ARRAY_REMOVE function#6653
VaggelisD merged 1 commit intomainfrom
mlee/annotate-array_remove

Conversation

@fivetran-MichaelLee
Copy link
Collaborator

@fivetran-MichaelLee fivetran-MichaelLee commented Jan 2, 2026

added type and tests for ARRAY_REMOVE

@fivetran-MichaelLee fivetran-MichaelLee self-assigned this Jan 2, 2026
@fivetran-MichaelLee fivetran-MichaelLee marked this pull request as ready for review January 2, 2026 17:19
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

SQLGlot Integration Test Results

Comparing:

  • this branch (sqlglot:mlee/annotate-array_remove, sqlglot version: mlee/annotate-array_remove)
  • baseline (main, sqlglot version: 28.5.1.dev54)

⚠️ Limited to dialects: snowflake

By Dialect

dialect main sqlglot:mlee/annotate-array_remove difference links
snowflake -> duckdb 626/1085 passed (57.7%) 626/1085 passed (57.7%) No change full result / delta
snowflake -> snowflake 981/1085 passed (90.4%) 981/1085 passed (90.4%) No change full result / delta

Overall

main: 2170 total, 1607 passed (pass rate: 74.1%), sqlglot version: 28.5.1.dev54

sqlglot:mlee/annotate-array_remove: 2170 total, 1607 passed (pass rate: 74.1%), sqlglot version: mlee/annotate-array_remove

Difference: No change

@VaggelisD
Copy link
Collaborator

@fivetran-MichaelLee Heads up, given that this does introduce a type annotation it'd be better to mark it as a breaking feat

@VaggelisD VaggelisD changed the title chore(optimizer): add tests for snowflake ARRAY_REMOVE function feat(snowflake)!: Type annotation for ARRAY_REMOVE function Jan 5, 2026
@VaggelisD VaggelisD merged commit 2fa29b1 into main Jan 5, 2026
13 checks passed
@VaggelisD VaggelisD deleted the mlee/annotate-array_remove branch January 5, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants