Skip to content

fix(duckdb): Fix NOT precedence for JSON extractions #6670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 7 commits into from
Jan 7, 2026
Merged

fix(duckdb): Fix NOT precedence for JSON extractions #6670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f8658a2
fix(duckdb): Fix NOT precedence for JSON extractions by wrapping in p…
Jan 6, 2026
71d1f8f
added snowflake to duckdb tests
Jan 6, 2026
bc47138
updated Snowflake to DuckDB to use scalar extract, tests will fail un…
Jan 6, 2026
f524e63
formatting
Jan 6, 2026
3360738
added more tests for json extraction precedence
Jan 7, 2026
27374fc
--amend
Jan 7, 2026
4f06674
removed unequivalent tests
Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlglot/dialects/duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ def _unix_to_time_sql(self: DuckDB.Generator, expression: exp.UnixToTime) -> str
return self.sql(to_timestamp)


WRAPPED_JSON_EXTRACT_EXPRESSIONS = (exp.Binary, exp.Bracket, exp.In)
WRAPPED_JSON_EXTRACT_EXPRESSIONS = (exp.Binary, exp.Bracket, exp.In, exp.Not)


def _arrow_json_extract_sql(self: DuckDB.Generator, expression: JSON_EXTRACT_TYPE) -> str:
Expand Down
18 changes: 18 additions & 0 deletions tests/dialects/test_duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,24 @@ def test_duckdb(self):
"JSON_EXTRACT_PATH_TEXT(x, '$.family')",
"x ->> '$.family'",
)
self.validate_all(
"SELECT NOT (data -> '$.value')",
read={
"snowflake": "SELECT NOT data:value",
},
)
self.validate_all(
"SELECT NOT (data -> '$.value.nested')",
read={
"snowflake": "SELECT NOT data:value:nested",
},
)
self.validate_all(
"SELECT (data -> '$.value') = 1",
read={
"snowflake": "SELECT data:value = 1",
},
)
self.validate_identity(
"SELECT {'yes': 'duck', 'maybe': 'goose', 'huh': NULL, 'no': 'heron'}"
)
Expand Down