Skip to content

feat(optimizer)!: Annotate ISINF(expr) for DuckDB #6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 3 commits into from
Jan 30, 2026
+9 −2
Merged

feat(optimizer)!: Annotate ISINF(expr) for DuckDB #6894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b63276
feat(optimizer)!: Annotate ISINF(expr) for DuckDB
AbhishekASLK Jan 30, 2026
6033918
moved to base
AbhishekASLK Jan 30, 2026
2e2c866
cleanup in bigquery
AbhishekASLK Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sqlglot/typing/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
exp.EndsWith,
exp.Exists,
exp.In,
exp.IsInf,
exp.LogicalAnd,
exp.LogicalOr,
exp.RegexpLike,
Expand Down
1 change: 0 additions & 1 deletion sqlglot/typing/bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ def _annotate_array(self: TypeAnnotator, expression: exp.Array) -> exp.Array:
**{
expr_type: {"returns": exp.DataType.Type.BOOLEAN}
for expr_type in {
exp.IsInf,
exp.IsNan,
exp.JSONBool,
exp.LaxBool,
Expand Down
9 changes: 8 additions & 1 deletion tests/fixtures/optimizer/annotate_functions.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ DOUBLE;
CBRT(tbl.double_col);
DOUBLE;

ISINF(tbl.float_col);
BOOLEAN;

# dialect: snowflake
TO_BINARY('test');
BINARY;
Expand Down Expand Up @@ -5610,4 +5613,8 @@ DOUBLE;

# dialect: duckdb
COS(tbl.double_col);
DOUBLE;
DOUBLE;

# dialect: duckdb
ISINF(tbl.float_col);
BOOLEAN;