Skip to content

Conversation

ppannuto
Copy link
Member

We have lots of MPU tests, and it's not necessarily obvious why.

This aims to give a "memory map" to the array of tests, as well as to make more obvious where you might start for any interactive testing.

@bradjc
Copy link
Contributor

bradjc commented Mar 20, 2025

Why do we need another sub folder?

@ppannuto
Copy link
Member Author

We don't need a subfolder, but I'll quote myself from the README updates for the rationale:

MPU test applications are necessarily somewhat fine-grained, as each MPU
violation results in termination of the test process.

As it can be annoying to flash myriad apps during development, the tests in the
top-level directory attempt to exercise all of the reads and writes of regions
that should work during normal operation (and allow use of a button to inject
faults for interactive testing). The unit/ folder holds all of the smaller
tests which attempt to violate access rules at each of the boundaries.

@bradjc
Copy link
Contributor

bradjc commented Mar 26, 2025

But we don't have any other tests. Let's just add the folder when we know we need it. We have many groups of tests, many of which can be annoying to run. I don't think there is anything different about MPU.

@ppannuto
Copy link
Member Author

Yes we do?

mpu_walk_region is still in the root folder here, and #497 adds a second root-level test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that this is the only Makefile in the diff that git doesn't seem to track as a rename? (at least using GitHub's diff settings / algorithm)

@lschuermann
Copy link
Member

and #497 adds a second root-level test.

Which is merged, so I'd say this seems good to go now.

@alevy alevy added this pull request to the merge queue Jun 26, 2025
Merged via the queue into master with commit a65b693 Jun 26, 2025
4 checks passed
@alevy alevy deleted the tests-reorg-mpu branch June 26, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants