Conversation
C23 is more pendantic than C11 about the function signature here.
This is a no-op at this point, as C23 didn't really break anything. The prior selection of C11 was mostly aribtrary. At the time the first libtock-c build infrastructure was built, C17 hadn't been ratified yet, but we needed some newer stuff than C99 provided, so we explicitly set things to C11 (well, gnu11). We have an impending need for the new C23 `#embed` compiler directive, so this version bump lays the groundwork. Future PRs may also look at other new C23 features; there are many that are likely useful to libtock-c.
Member
Author
|
Actually hold on, there's a few more (hopefully equally inconsequential) things to fix, e.g. Turns out changing |
alistair23
approved these changes
May 9, 2025
lschuermann
approved these changes
May 9, 2025
alevy
approved these changes
May 9, 2025
Member
alevy
left a comment
There was a problem hiding this comment.
I don't have a strong opinion about this. In principle, since this is mostly a no-op, it just makes it hard for people with older compilers to build this, on the other hand... let's use the new thing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically a no-op at this point, as C23 didn't really break anything*.
The prior selection of C11 was mostly arbitrary. At the time the first
libtock-c build infrastructure was built, C17 hadn't been ratified yet,
but we needed some newer stuff than C99 provided, so we explicitly set
things to C11 (well, gnu11).
We have an impending need for the new C23
#embedcompiler directive,so this version bump lays the groundwork.
Future PRs may also look at other new C23 features; there are many that
are likely useful to libtock-c.
*There was one function signature it's more persnickety about, which
is the other commit in this PR.