Skip to content

Yield-WaitFor: Update HMAC #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Yield-WaitFor: Update HMAC #532

wants to merge 3 commits into from

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jul 9, 2025

A couple things to review here:

  1. I created a hmac_types.h header file to share with libtock-sync. Thoughts on the naming? We might want to include shared functions too.
  2. I tried to implement the sync version "correctly" with the error handling it should have. Is that correct?
  3. I fixed a buffer name.

@ppannuto ppannuto mentioned this pull request Jul 21, 2025
Merged
@ppannuto
Copy link
Member

Closed in favor of #541.

@ppannuto ppannuto closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bradjc @ppannuto