tests/mpu_no_libc: fix walk-flash test memop call#535
Open
lschuermann wants to merge 1 commit intomasterfrom
Open
tests/mpu_no_libc: fix walk-flash test memop call#535lschuermann wants to merge 1 commit intomasterfrom
lschuermann wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mpu_no_libctest (introduced in #497) produces a load access fault on RISC-V in step 9. This step is supposed to read all flash addresses. However, it issues a memop call6, which returns the lowest address of the grant region for the app. This seems to be an off-by-one error, as memop5returns the first address after the end of the application's flash region (matching the loop condition in the code).However, this same issue exists for Cortex-M. I'm suprised this test has worked on Cortex-M targets. @ppannuto Any ideas as to why?
If this is the correct fix, I'll make the PR and in-code documentation consistently refer to memop
5instead.Here's the fault observed on RISC-V: