Skip to content

Enforce minimum compiler version and use now-standard [[nodiscard]] in favor of compiler attribute #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Enforce minimum compiler version and use now-standard [[nodiscard]] in favor of compiler attribute #539

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bb69a2f
c23: use now-standard [[nodiscard]] in favor of compiler attribute
ppannuto Jul 16, 2025
f4abc4d
workflows/ci: disable wget progress output spamming CI logs
lschuermann Jan 6, 2025
4d9d6fe
ci: update to latest LTS
ppannuto Jul 23, 2025
48041b0
build: check compiler version and enforce >= 13
ppannuto Jul 23, 2025
7b33503
build: add option to opt-out of compiler version check
ppannuto Jul 23, 2025
f0d6235
fix type-pun alias warning
ppannuto Jul 23, 2025
ea0ab80
build: only validate compiler version for used arches
ppannuto Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions libtock/tock.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,25 +194,25 @@ yield_waitfor_return_t yield_wait_for(uint32_t driver, uint32_t subscribe);
void tock_exit(uint32_t completion_code) __attribute__ ((noreturn));
void tock_restart(uint32_t completion_code) __attribute__ ((noreturn));

__attribute__ ((warn_unused_result))
[[ nodiscard ]]
syscall_return_t command(uint32_t driver, uint32_t command, int arg1, int arg2);

// Pass this to the subscribe syscall as a function pointer to
// be the Null Upcall.
#define TOCK_NULL_UPCALL 0

__attribute__ ((warn_unused_result))
[[ nodiscard ]]
subscribe_return_t subscribe(uint32_t driver, uint32_t subscribe, subscribe_upcall uc, void* userdata);

__attribute__ ((warn_unused_result))
[[ nodiscard ]]
allow_rw_return_t allow_readwrite(uint32_t driver, uint32_t allow, void* ptr, size_t size);

__attribute__ ((warn_unused_result))
[[ nodiscard ]]
allow_userspace_r_return_t allow_userspace_read(uint32_t driver,
uint32_t allow, void* ptr,
size_t size);

__attribute__ ((warn_unused_result))
[[ nodiscard ]]
allow_ro_return_t allow_readonly(uint32_t driver, uint32_t allow, const void* ptr, size_t size);

// Call the memop syscall.
Expand Down
Loading