gpio-async: convert to ywf #547
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjc
reviewed
Aug 15, 2025
| @@ -0,0 +1,20 @@ | |||
| #pragma once | |||
|
|
|||
| #include <libtock/peripherals/syscalls/gpio_async_syscalls.h> | |||
There was a problem hiding this comment.
Suggested change
| #include <libtock/peripherals/syscalls/gpio_async_syscalls.h> |
So we don't leak libtock in libtock-sync.
There was a problem hiding this comment.
It's there to avoid duplicating the DRIVER_NUM_GPIO_ASYNC, presumably for the same reason you have the same include here ( https://github.com/tock/libtock-c/pull/553/files#diff-28af97b25b50c3d619c7a3ba099e6a2ff6ebcf972c1fc84800fa932c3c1159d7R3 ) and elsewhere in #553.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile-tested only, fairly straight conversion.
There's a mild deviation from the style guide with the
wait_for_generic_commandinstead of 6 differentwait_for_[set|clear|...]methods. It mirrors how the driver itself is implemented, and I think is a cleaner design and easier to follow than lots of redundant syscall methods.More generally, I suspect as we port more of these we may find it makes sense to rethink the guidance around ywf methods, but I'm not a that level of confident with just this one.