Conversation
Needed for IDEs to spin up the appropriate lsp for the Rust version
alevy
force-pushed
the
feature/upgrade/rust-1.88
branch
from
a0bd1a2 to
5e2941f
Compare
ppannuto
approved these changes
Sep 12, 2025
| let pan: u16 = 0xcafe; | ||
| let addr_short: u16 = 0xdead; | ||
| let addr_long: u64 = 0xdead_dad; | ||
| let addr_long: u64 = 0xdeaddad; |
Member
There was a problem hiding this comment.
weird change, but whatever (maybe because the break wasn't on a byte it removed it? I'll agree, that's a bit misleading)
Contributor
There was a problem hiding this comment.
But ieee802154_rx_tx.rs has the same pattern, which wasn't changed.
libtock-rs/examples/ieee802154_rx_tx.rs
Line 20 in 5e2941f
Member
Author
There was a problem hiding this comment.
Clippy complains about it variously (it's not easy/possible to run clippy once on the all crates in this repos, so I caught some but not others, and enough to get make test to quite down).
Indeed, it doesn't like that it's not on a byte boundary. It suggested 0x0dea_ddad which I thought was worse than just combining them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the rust-toolchain to 1.88 stable.
Individual commits should make for easy review:
rust-analyzerto therust-toolchain.tomlfile (OK, this isn't striclty related but it basically helps keep IDE using the same Rust as the command line).rust-toolchain.tomlcargo clippyandcargo fmt.