Merged
Conversation
Right now the screen driver calls yield no matter what command returns. However, if a command returns an error no upcall will be called. This checks the return from the command and only calls yield if command returned success.
val.is_err() return val -> val?;
jrvanwhy
previously approved these changes
Sep 17, 2025
Collaborator
jrvanwhy
left a comment
jrvanwhy
left a comment
There was a problem hiding this comment.
Ideally we would have a unit test to verify this fix as well.
If the command errors there will be no upcall.
the kernel will not issue an upcall if the command returns an error.
Contributor
Author
|
We did actually have unittests to verify the behavior, but the fake kernel didn't match the real kernel. |
alevy
approved these changes
Sep 22, 2025
jrvanwhy
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the screen driver calls yield no matter what command returns. However, if a command returns an error no upcall will be called. This checks the return from the command and only calls yield if command returned success.