Skip to content

Conversation

@rico-chet
Copy link

@rico-chet rico-chet commented Jul 18, 2020

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • N/A If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • N/A Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

@karbassi
Copy link
Member

@rico-chet great idea.

Can you make sure it runs and works?

@rico-chet
Copy link
Author

Oops, this PR is accidental right now, I actually wanted to see what happens when I add windows-latest as platform.
I am writing a bug, so this can be worked on as usual.

@karbassi karbassi linked an issue Jul 18, 2020 that may be closed by this pull request
@karbassi
Copy link
Member

karbassi commented Aug 4, 2021

Related to #352

@karbassi karbassi closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests failing on Windows (GitHub Actions)

2 participants