Skip to content

Remove the default LoRA rank warning #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azahed98 merged 2 commits into from
Dec 18, 2024
Merged

Remove the default LoRA rank warning #225

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18fbb74
Remove the default LoRA rank warning
Dec 18, 2024
bc307c5
Update to 1.3.10
Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/together/cli/api/finetune.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,7 @@ def create(
"batch_size": model_limits.lora_training.max_batch_size,
"learning_rate": 1e-3,
}
log_warn_once(
f"The default LoRA rank for {model} has been changed to {default_values['lora_r']} as the max available.\n"
f"Also, the default learning rate for LoRA fine-tuning has been changed to {default_values['learning_rate']}."
)

for arg in default_values:
arg_source = ctx.get_parameter_source("arg") # type: ignore[attr-defined]
if arg_source == ParameterSource.DEFAULT:
Expand Down
Loading