Skip to content

Accept strings for checkpoint type on download #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mryab merged 12 commits into from
May 13, 2025
Merged

Accept strings for checkpoint type on download #308

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f70976b
add .value
nbroad1881 May 6, 2025
eec18ed
Change type hints to include str, convert to str
nbroad1881 May 8, 2025
90d5a6d
Cast to enum instead of str
nbroad1881 May 8, 2025
9b15370
format and add try/except
nbroad1881 May 8, 2025
b1fe94e
fix comment
nbroad1881 May 8, 2025
8507a39
remove square brackets in comprehension
nbroad1881 May 12, 2025
c966a21
version 1.5.7 -> 1.5.8
nbroad1881 May 12, 2025
b2de6d0
Merge branch 'main' into nbroad/downloadcheckpointtype-value-fix
nbroad1881 May 13, 2025
fb2d097
fix types
nbroad1881 May 13, 2025
aede737
1.5.8->1.5.9
nbroad1881 May 13, 2025
17a9744
union -> |
nbroad1881 May 13, 2025
763ee6d
change union -> | in docstring
nbroad1881 May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/together/resources/finetune.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,12 +614,12 @@ def download(
)
url += "&checkpoint=model_output_path"
elif isinstance(ft_job.training_type, LoRATrainingType):
if checkpoint_type == DownloadCheckpointType.DEFAULT:
checkpoint_type = DownloadCheckpointType.MERGED
if checkpoint_type == DownloadCheckpointType.DEFAULT.value:
checkpoint_type = DownloadCheckpointType.MERGED.value

if checkpoint_type == DownloadCheckpointType.MERGED:
if checkpoint_type == DownloadCheckpointType.MERGED.value:
url += f"&checkpoint={DownloadCheckpointType.MERGED.value}"
elif checkpoint_type == DownloadCheckpointType.ADAPTER:
elif checkpoint_type == DownloadCheckpointType.ADAPTER.value:
url += f"&checkpoint={DownloadCheckpointType.ADAPTER.value}"
else:
raise ValueError(
Expand Down
Loading