Conversation
| url: '*://*.gitlab.com/*', | ||
| name: 'Gitlab' | ||
| name: 'Gitlab', | ||
| file: 'gitlab.js' |
There was a problem hiding this comment.
this line was automatically added by update-origins.js script.
|
seems to me that CI job running update-origins is half-baked, existing integrations were not modified to add the header. also there's nothing documented about format of the header in CONTRIBUTING.md, and the update-origins.js itself has 0 comments about logic or what should it be doing, some obfuscation contest candidate there. |
|
Should be rather trivial to write a script that:
but given past slow and negative experience with this repo, I would not do that unless someone explicitly asks to do that. also, the error that the script outputs, should guide the user to go to |
|
Also, CI for update-origins is set up incorrectly. it runs in the context of the contributing user repository: so, it doesn't appear at all under pull request: probably another reason why other integrations lack the header. I just happened to read my email to see the CI failure. |
🌟 What does this PR do?
Fixes error reported by CI:
reverse-engineered update-origins.js to understand what the hell the error means, as there's definitely nothing written about this in docs/CONTRIBUTING.md