Resources: make cover_image field non-nullable#19
Merged
AdityaKhatri merged 1 commit intodevelopfrom Apr 9, 2026
Merged
Conversation
sudip-khanal
changed the title
AdityaKhatri
requested changes
Apr 8, 2026
| @@ -1,4 +1,4 @@ | |||
| # Generated by Django 5.2.9 on 2026-03-17 08:23 | |||
Contributor
There was a problem hiding this comment.
Why is this migration renamed?
Contributor
Author
There was a problem hiding this comment.
Because there are two migration files with the same name.
Contributor
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughMigration and model updates make Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
sudip-khanal
force-pushed
the
fix/make-image-field-required
branch
from
1f4988b to
ebe51a8
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/tool_picker/models.py (1)
189-192: Replace the standalone string block with a real class docstring/comment.Line 189 adds a no-op string expression in the class body; it won’t be part of
OrdinalTypeEnum.__doc__and can be flagged by linters as “string statement has no effect.”Proposed cleanup
class OrdinalTypeEnum(models.IntegerChoices): - """Enum representing scale of ordinal type question.""" - - """ - Note: The enum labels are intentionally descriptive and user-friendly so they can be - used directly in the frontend UI and remain consistent with design requirements. - """ + """Enum representing scale of ordinal type question. + + Note: Enum labels are intentionally descriptive and user-friendly so they can be used + directly in the frontend UI and remain consistent with design requirements. + """🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/tool_picker/models.py` around lines 189 - 192, The descriptive text is currently a standalone string expression inside the class body (causing a no-op and linter warning); update OrdinalTypeEnum so the text becomes a real class docstring by placing the triple-quoted string immediately after the class header (so OrdinalTypeEnum.__doc__ is populated), or alternatively convert the text to a comment (prefix with #) above the class; remove the existing stray string expression to eliminate the no-op.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/tool_picker/models.py`:
- Around line 189-192: The descriptive text is currently a standalone string
expression inside the class body (causing a no-op and linter warning); update
OrdinalTypeEnum so the text becomes a real class docstring by placing the
triple-quoted string immediately after the class header (so
OrdinalTypeEnum.__doc__ is populated), or alternatively convert the text to a
comment (prefix with #) above the class; remove the existing stray string
expression to eliminate the no-op.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 74efd0aa-f903-4f0b-a08f-e2d202ca3502
📒 Files selected for processing (3)
apps/resources/migrations/0004_alter_casestudy_cover_image_requestdemo.pyapps/resources/models.pyapps/tool_picker/models.py
💤 Files with no reviewable changes (1)
- apps/resources/models.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Casestudycover_image field non-nullableN/AenumThis PR doesn't introduce any:
printThis PR contains valid:
Summary by CodeRabbit