test(axum-extra): improve response_not_set_filename test invariants#3574
Open
darth-raijin wants to merge 3 commits intotokio-rs:mainfrom
Open
test(axum-extra): improve response_not_set_filename test invariants#3574darth-raijin wants to merge 3 commits intotokio-rs:mainfrom
response_not_set_filename test invariants#3574darth-raijin wants to merge 3 commits intotokio-rs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strengthen test invariants for
file_stream.rsby deriving values where possible and replacing magic values with constants.Motivation
To improve test quality and reduce brittleness when changing test data, this PR updates the
response_not_set_filenametest to derive values (likecontent-length) from the test payload and to use existing constants (like mime types and headers).Solution
file_contentandsizeonce at the top of the test to enable reuse for assertions and usage in the/filehandlerhttp::headermime