Convert negative CQE results to io::Error#376
Open
asayers wants to merge 3 commits intotokio-rs:masterfrom
Open
Convert negative CQE results to io::Error#376asayers wants to merge 3 commits intotokio-rs:masterfrom
asayers wants to merge 3 commits intotokio-rs:masterfrom
Conversation
Member
|
I don't reject this, but it would be a break change. would you can to add another method that returns |
Author
|
Yes, that's probably a good idea. |
Member
|
Of course, you can consider a better name. |
Quick access to the raw i32 is still possible via the `raw_result()` method. The same change is applied to `Entry32` to keep the APIs in-sync.
02107a7 to
b72c658
Compare
Author
|
It's been a couple of weeks and I haven't thought of anything better, so I renamed it to |
quininer
reviewed
Dec 26, 2025
| assert_eq!(cqes[0].result(), -libc::ECANCELED); // -ECANCELED | ||
| assert_eq!(cqes[1].result(), 0); // the number of requests cancelled | ||
| assert_eq!( | ||
| cqes[0].io_result().unwrap_err().raw_os_error().unwrap(), |
Member
There was a problem hiding this comment.
I think using io_result in here seems not good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following text is found in many io_uring man pages:
My understanding is that a negative value in the res field is always a negated errno. Converting negative values to
io::Errorremoves a footgun, and is often more convenient. You can recover the original errno withError::raw_os_error().(This is a backport of jordanisaacs/rustix-uring#11 and jordanisaacs/rustix-uring#15)