Skip to content

add ?Sized trait bound to RwLock#401

Merged
Darksonn merged 1 commit intotokio-rs:masterfrom
pedrocarlo:unsized-rwlock
Jan 12, 2026
Merged

add ?Sized trait bound to RwLock#401
Darksonn merged 1 commit intotokio-rs:masterfrom
pedrocarlo:unsized-rwlock

Conversation

@pedrocarlo
Copy link
Contributor

@pedrocarlo pedrocarlo commented Jan 11, 2026

Closes #400

Had to add a custom Debug impl because for the current MSRV, the Debug impl of the guards do not contain the ?Sized bound.

https://doc.rust-lang.org/1.73.0/src/std/sync/rwlock.rs.html#549-553

@pedrocarlo pedrocarlo marked this pull request as ready for review January 11, 2026 17:56
@pedrocarlo pedrocarlo force-pushed the unsized-rwlock branch 3 times, most recently from 50847ae to c0bf39b Compare January 11, 2026 18:11
Copy link
Member

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 6abd413 into tokio-rs:master Jan 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add T: ?Sized bound to RwLock

2 participants