Fix various build errors #1898
Merged
Fix various build errors #1898
+11
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
changed the title
Darksonn
force-pushed
the
fix-pipe-waker
branch
2 times, most recently
from
55030d4 to
3e0689d
Compare
Darksonn
force-pushed
the
fix-pipe-waker
branch
from
3e0689d to
423a814
Compare
Darksonn
changed the title
Darksonn
force-pushed
the
fix-pipe-waker
branch
from
93c3898 to
038626f
Compare
reregister is used by sourcefd, which is always available under os-ext, so selectors should always provide reregister when os-ext is enabled even if cfg(unix) fails
Darksonn
force-pushed
the
fix-pipe-waker
branch
from
038626f to
e903b37
Compare
Thomasdezeeuw
approved these changes
Aug 28, 2025
Collaborator
Thomasdezeeuw
left a comment
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
All these macros and features are becoming such a pain. Anyway, thanks for fixing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the condition for
waker/pipe.rsand the condition forselector/kqueue.rsare triggered at the same time, then there is a compilation failure unlessos-extis enabled becauseSelector::registeris unavailable. Fixselector/kqueue.rsby makingSelector::registeravailable unconditionally, which matches the otherselectorimplementations.Also, when
os-extis enabled, andsys/unixis used, butcfg(unix)is false, there is a build failure becausereregisteris gated behindall(unix, feature="os-ext")which should be simplified tofeature="os-ext". This is becausesys/unix/sourcefd.rsis always used withos-extand it always needsreregister. To fix this,cfg_io_source!is replaced withcfg_any_os_ext!.As for wasi, a dummy selector needs to be enabled also when
netis enabled withoutos-ext. To fix that, replacecfg_os_ext!withcfg_any_os_ext!in the shell selector.The espidf build is failing due to rust-lang/rust#145746. The haiku build is failing due to rust-lang/rust#145952.