Skip to content

build: upgrade windows-sys 0.52 → 0.59 #7117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
+7 −5
Merged

build: upgrade windows-sys 0.52 → 0.59 #7117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a62cc8
build: upgrade `windows-sys` 0.52 → 0.59
ErichDonGubler Jan 22, 2025
da52dfb
fixup! build: upgrade `windows-sys` 0.52 → 0.59
ErichDonGubler Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ httpdate = "1.0"
once_cell = "1.5.2"

[target.'cfg(windows)'.dev-dependencies.windows-sys]
version = "0.52"
version = "0.59"

[[example]]
name = "chat"
Expand Down
8 changes: 4 additions & 4 deletions tokio/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ pin-project-lite = "0.2.11"

# Everything else is optional...
bytes = { version = "1.2.1", optional = true }
mio = { version = "1.0.1", optional = true, default-features = false }
mio = { version = "1.0.4", optional = true, default-features = false }
parking_lot = { version = "0.12.0", optional = true }

[target.'cfg(not(target_family = "wasm"))'.dependencies]
Expand All @@ -106,7 +106,7 @@ tracing = { version = "0.1.29", default-features = false, features = ["std"], op
[target.'cfg(all(tokio_uring, target_os = "linux"))'.dependencies]
io-uring = { version = "0.7.6", default-features = false }
libc = { version = "0.2.168" }
mio = { version = "1.0.1", default-features = false, features = ["os-poll", "os-ext"] }
mio = { version = "1.0.4", default-features = false, features = ["os-poll", "os-ext"] }
slab = "0.4.9"

# Currently unstable. The API exposed by these features may be broken at any time.
Expand All @@ -123,11 +123,11 @@ libc = { version = "0.2.168" }
nix = { version = "0.29.0", default-features = false, features = ["aio", "fs", "socket"] }

[target.'cfg(windows)'.dependencies.windows-sys]
version = "0.52"
version = "0.59"
optional = true

[target.'cfg(windows)'.dev-dependencies.windows-sys]
version = "0.52"
version = "0.59"
features = [
"Win32_Foundation",
"Win32_Security_Authorization",
Expand Down
3 changes: 2 additions & 1 deletion tokio/src/net/windows/named_pipe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ use std::ffi::OsStr;
use std::io::{self, Read, Write};
use std::pin::Pin;
use std::ptr;
use std::ptr::null_mut;
use std::task::{Context, Poll};

use crate::io::{AsyncRead, AsyncWrite, Interest, PollEvented, ReadBuf, Ready};
Expand Down Expand Up @@ -2556,7 +2557,7 @@ impl ClientOptions {
attrs as *mut _,
windows_sys::OPEN_EXISTING,
self.get_flags(),
0,
null_mut(),
);

if h == windows_sys::INVALID_HANDLE_VALUE {
Expand Down
3 changes: 2 additions & 1 deletion tokio/src/process/windows.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ use std::os::windows::prelude::{AsRawHandle, IntoRawHandle, OwnedHandle, RawHand
use std::pin::Pin;
use std::process::Stdio;
use std::process::{Child as StdChild, ExitStatus};
use std::ptr::null_mut;
use std::sync::Arc;
use std::task::{Context, Poll};

Expand Down Expand Up @@ -119,7 +120,7 @@ impl Future for Child {
}
let (tx, rx) = oneshot::channel();
let ptr = Box::into_raw(Box::new(Some(tx)));
let mut wait_object = 0;
let mut wait_object = null_mut();
let rc = unsafe {
RegisterWaitForSingleObject(
&mut wait_object,
Expand Down
Loading