fix(process): upgrade Command::spawn_with to use FnOnce #7511
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #7249 (comment), since the
with
closure is only called once, it can be upgraded toFnOnce
to allow mutation.Solution
Changed
Fn
toFnOnce
inCommand::spawn_with
Tested with the following code
*I don't know all the implications of piping stdout into stdin in this way versus the one in the module documentation that uses
TryInto<Stdio>
on the spawned child. This PR isn't intended to solve that problem anyway, so I didn't add any automated test.