Skip to content

task: add tests for spawn_local and spawn_local_on #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 16, 2025
Merged

task: add tests for spawn_local and spawn_local_on #7609

merged 20 commits into from
Oct 16, 2025
+773 −4

Conversation

FrancescoV1985
Copy link
Contributor

Fixes: #7562

Motivation

Improve the test coverage of task containers on LocalRuntime

Solution

Added new tests for JoinSet, JoinMap, TaskTracer

@ADD-SP ADD-SP added A-tokio-util Area: The tokio-util crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate M-task Module: tokio/task labels Sep 15, 2025
ADD-SP
ADD-SP reviewed Sep 15, 2025
View reviewed changes
@ADD-SP ADD-SP added the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Sep 15, 2025
@ADD-SP
Copy link
Member

ADD-SP commented Sep 25, 2025

Hi @FrancescoV1985 , any update on this PR?

@FrancescoV1985
Copy link
Contributor Author

FrancescoV1985 commented Sep 25, 2025 •
edited
Loading

Hi @FrancescoV1985 , any update on this PR?
Hi @ADD-SP
I have updated the code (see pm on discord)

ADD-SP
ADD-SP reviewed Sep 26, 2025
View reviewed changes
Copy link
Member

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try to reduce the duplicated code from test code? Also, Are the tests for TaskTracker in the scope of this PR?

@FrancescoV1985
Copy link
Contributor Author

FrancescoV1985 commented Sep 26, 2025 •
edited
Loading

Could you try to reduce the duplicated code from test code? Also, Are the tests for TaskTracker in the scope of this PR?

I committed the tests for TaskTracker. I still need to add comments and double check. I will pm you for some clarifications..

ADD-SP
ADD-SP reviewed Oct 7, 2025
View reviewed changes
Copy link
Member

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sync changes from the base branch to fix the CI failures.

@ADD-SP ADD-SP removed the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Oct 8, 2025
ADD-SP
ADD-SP reviewed Oct 8, 2025
View reviewed changes
@ADD-SP ADD-SP added the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Oct 8, 2025
ADD-SP
ADD-SP reviewed Oct 8, 2025
View reviewed changes
Copy link
Member

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the mod name has already indicated the scope, we can improve the test name, also change the comments.

Feel free to re-write the suggested changes.

@FrancescoV1985 @ADD-SP
Apply suggestions from code review
86405b6 
Commit suggestions for task_join_set.rs

Co-authored-by: Qi <[email protected]>
@ADD-SP ADD-SP removed the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Oct 9, 2025
@ADD-SP ADD-SP mentioned this pull request Oct 10, 2025
Closed
ADD-SP
ADD-SP reviewed Oct 11, 2025
View reviewed changes
@ADD-SP ADD-SP added the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Oct 12, 2025
@mattiapitossi mattiapitossi mentioned this pull request Oct 15, 2025
Merged
@ADD-SP ADD-SP removed the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Oct 15, 2025
ADD-SP
ADD-SP reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, could you resolve the merge conflicts?

@ADD-SP ADD-SP changed the title Add new tests for JoinSet, JoinMap, TaskTracer and LocalRuntime task: add tests for spawn_local and spawn_local_on Oct 16, 2025
ADD-SP
ADD-SP approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ADD-SP ADD-SP merged commit 5dacc2e into tokio-rs:master Oct 16, 2025
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

Assignees

No one assigned

Labels

A-tokio Area: The main tokio crate A-tokio-util Area: The tokio-util crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-task Module: tokio/task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the test coverage of task containers on LocalRuntime

2 participants

@FrancescoV1985 @ADD-SP