-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Prepare Tokio v1.43.3 #7679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+87
−74
Closed
Prepare Tokio v1.43.3 #7679
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b1e69e5
ci: pin the rust version for wasm tests (#7518)
mox692 4fee6e3
ci: update macros_type_mismatch for Rust 1.90.0 (#7630)
ADD-SP b9feac8
runtime: use release in `wake_by_ref()` even if already woken (#7622)
frostyplanet da292df
sync: close the `broadcast::Sender` in `broadcast::Sender::new()` (#7…
martin-g 49b3318
process: fix error when runtime is shut down on nightly-2025-10-12 (#…
Darksonn bd4c3dd
deps: bump the locked tracing-subscriber to `0.3.20`
ADD-SP 90551d2
deps: bump the locked slap to `0.4.11`
ADD-SP de6ef21
chore: prepare Tokio v1.43.3
ADD-SP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ name = "tokio" | |
| # - README.md | ||
| # - Update CHANGELOG.md. | ||
| # - Create "v1.x.y" git tag. | ||
| version = "1.43.2" | ||
| version = "1.43.3" | ||
| edition = "2021" | ||
| rust-version = "1.70" | ||
| authors = ["Tokio Contributors <[email protected]>"] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -656,3 +656,15 @@ async fn receiver_recv_is_cooperative() { | |
| _ = tokio::task::yield_now() => {}, | ||
| } | ||
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn broadcast_sender_new_must_be_closed() { | ||
| let capacity = 1; | ||
| let tx: broadcast::Sender<()> = broadcast::Sender::new(capacity); | ||
|
|
||
| tx.send(()).unwrap_err(); | ||
|
|
||
| let _rx = tx.subscribe(); | ||
|
|
||
| tx.send(()).unwrap(); | ||
| } | ||
|
Comment on lines
+660
to
+670
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This diverges the #7629 due to the |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose to not backport the #7537 because it is a quite large change, changes on LTS should be minimal unless absolutely necessary.