Add support for column information in callsite metadata.#3277
Open
raldone01 wants to merge 2 commits intotokio-rs:v0.2.xfrom
Open
Add support for column information in callsite metadata.#3277raldone01 wants to merge 2 commits intotokio-rs:v0.2.xfrom
raldone01 wants to merge 2 commits intotokio-rs:v0.2.xfrom
Conversation
raldone01
requested review from
a team,
carllerche,
davidbarsky and
hawkw
as code owners
Co-authored-by: raldone01 <raldone01@gmail.com> Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
raldone01
force-pushed
the
location-column-support
branch
2 times, most recently
from
ddb3c56 to
456cc3b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Fix minor formatting.
raldone01
force-pushed
the
location-column-support
branch
from
456cc3b to
cfa6e91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #1011 to the current
v0.2.x.I hope this makes it into
0.2#922.Motivation
Column information is nice to have and improves jumps from the console into the editor.
Closes #1011.