[tracing-appender] Use file's mtime instead of created time to sort. #3288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, rolling based on modified time and created time should not be much different. On the other hand, because the created time attribute has higher requirements for the Linux kernel version (>=4.11), while the modified time does not have this restriction, it has a wider range of usage scenarios. When the host Linux kernel version is less than 4.11, the roll function is not available, which will lead to more and more log files, and then cause the disk to be full.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, rolling based on modified time and created time should not be much different.
On the other hand, because the created time attribute has higher requirements for the Linux kernel version (>=4.11), while the modified time does not have this restriction, it has a wider range of usage scenarios.
When the host Linux kernel version is less than 4.11, the roll function is not available, which will lead to more and more log files, and then cause the disk to be full.