feat(subscriber): Add with_span_list implementation for all standard formats.#3397
Open
humb1t wants to merge 1 commit intotokio-rs:mainfrom
Open
feat(subscriber): Add with_span_list implementation for all standard formats.#3397humb1t wants to merge 1 commit intotokio-rs:mainfrom
humb1t wants to merge 1 commit intotokio-rs:mainfrom
Conversation
humb1t
force-pushed
the
with_span_list_for_all_formats
branch
from
13c5c56 to
52236aa
Compare
humb1t
force-pushed
the
with_span_list_for_all_formats
branch
from
52236aa to
1a095ff
Compare
Author
|
Will ping in the comments from time to time to keep PR active. |
|
Is there any activity on this PR? The feature should lighten the logs by removing the repeated span inclusions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As a "out-of-the-box" subscribers user, I want to be able to skip formatting of parent spans not only in Json formatter implementation, but also for Full, Pretty and Compact.
I discovered that one PR was made with attempt to add these implementations: #3357 (unfortunately it wasn't finished), and there was an issue asking for such functionality: #2805
As I see, such implementations are wanted by community, that's why I decided to contribute them.
Solution
Solution is simple and straightforward - I extracted
display_span_listboolean flag from Json formatter to mainFormatstruct which later used in allFormatEventtrait implementations.