Conversation
teskje
force-pushed
the
tcpstream-ready
branch
from
49ab09b to
2b0cde8
Compare
This adds a `TcpStream::ready` method, increasing compatibility with the tokio API. This implementation only supports `READABLE` and `WRITABLE` interests. If `ready` is invoked without any supported interests, it hangs forever, matching tokio's current behavior. Note that this implementation of `TcpStream::ready` takes `&mut self`, whereas tokio's takes `&self`. This deviation is currently required because peeking the read buffer requires `&mut self` in turmoil. We can fix that independently.
teskje
force-pushed
the
tcpstream-ready
branch
from
2b0cde8 to
79d954e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a TcpStream::ready method, increasing compatibility with the tokio API.
This implementation only supports
READABLEandWRITABLEinterests. Ifreadyis invoked without any supported interests, it hangs forever, matching tokio's current behavior.Note that this implementation of
TcpStream::readytakes&mut self, whereas tokio's takes&self. This deviation is currently required because peeking the read buffer requires&mut selfin turmoil. We can fix that once/if #260 lands.