Merged
Conversation
This branch adds a FlowControl mechanism that sidechannels the queues. The control handling process essentially applies backpressure by tracking the in flight requests end to end and enforcing the tcp_capacity on the system.
Collaborator
Author
Collaborator
|
Changes look good to me! It'll be nice to have backpressure. Probably want a review from @mcches too |
Previous change eliminated a panic message that was using this. Removed local_addr on the SocketStream that is no longer used.
Adds lo tests for validating the turmoil's special casing around loopback handling in turmoil. Also addresses some formatting and clippy errors.
The tests were using sleeps to emulate a busy server. Replaces them with pending, and removes an unnecessary hold in one of the tests.
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds a FlowControl mechanism that sidechannels the queues. The control handling process essentially applies backpressure by tracking the in flight requests end to end and enforcing the tcp_capacity on the system.
The approach is not perfect, since it's side channeling the backpressure, but I tried to couple the paths and the model as straight as I could without restructuring the world. Most of the setup is essentially tracking the path where the streams are created with a flow controller. Behaviorally this should be the same as TCP outside the fact that it's not tracking through the channel and buffers used by turmoil, and instead using a full path end-to-end.