Skip to content

Conversation

@JanCizmar
Copy link
Contributor

@JanCizmar JanCizmar commented Feb 10, 2026

Summary

Vue SSR e2e tests fail in CI because the testapp's npm install --force resolves vike@^0.4.193 to the latest 0.4.x, which is broken:

  • 0.4.237 has a build error (Cannot read properties of undefined (reading 'client'))
  • 0.4.238+ requires vite 6, but the testapp uses vite 5

This pins vike to 0.4.236 — the latest version that works with vite 5.

Test plan

  • Vue SSR e2e tests pass in CI (both dev and prod)

Summary by CodeRabbit

  • Chores
    • Updated framework version in test application environment for improved compatibility and stability.

CI uses npm install which ignores the pnpm lockfile and resolves
^0.4.193 to latest 0.4.x. Versions 0.4.237+ are broken (0.4.237 has
a build error, 0.4.238+ requires vite 6). Pinning to 0.4.236, the
latest working version with vite 5.
@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2026

Walkthrough

Updated the "vike" dependency in the Vue SSR test app from ^0.4.193 to 0.4.236, removing the caret prefix to pin to an exact version rather than allowing minor version upgrades.

Changes

Cohort / File(s) Summary
Dependency Version Update
testapps/vue-ssr/package.json
Updated "vike" dependency from ^0.4.193 to 0.4.236, pinning to exact version instead of allowing minor updates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A vike version hops into place,
From carets removed without a trace,
Two-three-six stands firm and true,
No more drifting—locked in view! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically summarizes the main change: pinning the vike dependency version to 0.4.236 in the vue-ssr testapp, which directly addresses the CI failure described in the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jancizmar/pin-vike-version

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@JanCizmar JanCizmar merged commit f49ede5 into main Feb 10, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant