Skip to content

Improved Swift Interop#6

Merged
DatL4g merged 1 commit intomasterfrom
jeffretz/skie
Sep 2, 2025
Merged

Improved Swift Interop#6
DatL4g merged 1 commit intomasterfrom
jeffretz/skie

Conversation

@DatL4g
Copy link
Collaborator

@DatL4g DatL4g commented Aug 23, 2025

This change massively improves the usage in Swift.

⚠️ It is not meant to replace https://github.com/tolgee/tolgee-mobile-swift-sdk but to make the usage in Kotlin multiplatform projects way easier.

Some Compose multiplatform projects for example use platform specific views with UIKitView and can access Tolgee within now.

Read more here: https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-uikit-integration.html

@DatL4g DatL4g requested a review from Anty0 August 23, 2025 21:29
Copy link
Collaborator

@Anty0 Anty0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, when enabling this, are we locking ourselves into using that Skie library? Is there a way to let users handle preprocessing for coroutines with their preferred library, or how can we avoid issues if we want to replace the current library with a better one in the future?

@DatL4g
Copy link
Collaborator Author

DatL4g commented Sep 1, 2025

We are not really locked to using Skie in the future.

Is there a way to let users handle preprocessing for coroutines with their preferred library

No the provided package is precompiled, otherwise they would have to compile it themself.

However, this library "converts" Flows which can't be used directly in Swift, to AsyncSequence and Combine.Publisher.
Other libraries doing something similar produce the same async and combine bindings.

People can decide which of these bindings they want to use.

@Anty0
Copy link
Collaborator

Anty0 commented Sep 2, 2025

I mean, we would need to recreate the AsyncSequences and Combine.Publishers with the same signatures using a different library to switch without breaking changes, but feel free to merge the PR. Hopefully, we won't need to do that ^^

@DatL4g DatL4g merged commit db416c5 into master Sep 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants