Skip to content

fix: open import translations help links in new tab #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aditya-mitra wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −5
Open

fix: open import translations help links in new tab #3349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cdddff
make the help icons of equal size
aditya-mitra Dec 15, 2025
19536e5
open corresponding links in new tab
aditya-mitra Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions webapp/src/views/projects/import/component/ImportSettingsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,11 @@ export const ImportSettingsPanel: FC = (props) => {
checked={state?.convertPlaceholdersToIcu}
{...additionalCheckboxProps}
customHelpIcon={
<StyledLink href={DOCS_LINKS.importingPlaceholders}>
<StyledLink
href={DOCS_LINKS.importingPlaceholders}
rel="noreferrer noopener"
target="_blank"
>
<HelpCircle className="icon" />
</StyledLink>
}
Expand All @@ -126,10 +130,12 @@ export const ImportSettingsPanel: FC = (props) => {
label={t('import_override_key_descriptions_label')}
checked={state?.overrideKeyDescriptions}
customHelpIcon={
<StyledLink href={DOCS_LINKS.importOverridingDescriptions}>
<Box display="flex">
<HelpCircle className="icon" />
</Box>
<StyledLink
href={DOCS_LINKS.importOverridingDescriptions}
rel="noreferrer noopener"
target="_blank"
>
<HelpCircle className="icon" />
</StyledLink>
}
{...additionalCheckboxProps}
Expand All @@ -143,6 +149,11 @@ export const ImportSettingsPanel: FC = (props) => {
hint={t('import_only_update_without_add_key_label_hint')}
label={t('import_only_update_without_add_key_label')}
checked={state?.createNewKeys}
customHelpIcon={
<StyledLink>
<HelpCircle className="icon" />
</StyledLink>
}
{...additionalCheckboxProps}
/>
</StyledPanelBox>
Expand Down