Open
Conversation
added 2 commits
April 19, 2016 10:42
rewrote/added some calls to trigger the neccessary hooks of plugin: wp-amazon-s3-and-cloudfront
This was referenced Apr 19, 2016
Open
|
+1 Would love this in main, we've disabled Amazon S3 Plugin in the meantime. |
Author
|
We still use Amazon S3 Plugin and the merge is included in a docker build process. I can write down the details if you are interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote some calls, so that the necessary hooks from the plugin wp-amazon-s3-and-cloudfront are triggered.
I think there is still room for improvement and i'm happy for feedback.