This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Change MainWindow to be a Gtk.Window instead of Gtk.Dialog#64
Open
marcelobalexandre wants to merge 3 commits intotomatoers:masterfrom
Open
Change MainWindow to be a Gtk.Window instead of Gtk.Dialog#64marcelobalexandre wants to merge 3 commits intotomatoers:masterfrom
marcelobalexandre wants to merge 3 commits intotomatoers:masterfrom
Conversation
marcelobalexandre
force-pushed
the
convert-dialog-into-window
branch
from
0c3ca80 to
d625293
Compare
megatux
approved these changes
Jul 9, 2019
megatux
left a comment
megatux
left a comment
There was a problem hiding this comment.
Code looks good to me. Also built it & installed and seems to work fine (ElementaryOS Juno, with i3 wm. I'm not sure why i3 still treats the window as a dialog but that seems to be unrelated)
Author
|
@megatux thanks for reviewing. |
ryonakano
reviewed
Jul 17, 2019
| setup_headerbar (); | ||
| setup_stack (); | ||
| content.add (slide); | ||
| content.pack_start (slide, false, false, 0); |
There was a problem hiding this comment.
Suggested change
| content.pack_start (slide, false, false, 0); | |
| content.add (slide); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #46