Open
Conversation
added 2 commits
July 5, 2016 13:59
Stylesheets are preprocessed before fed into tokenizer. The preprocessing means: - dropping comments, block and single line comments are handles - handling imports: @import ‘my.file.nss’ Drawbacks: - the preprocessor uses NSRegularExpression to check the input which could be slow if intensively used, however in this case we are checking for 3 simple patterns. - the location-related token properties got broken due the imports, however they aren’t used on NUI-level at all.
|
Hey guys, Can someone take a look at this? Import would be super useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stylesheets are preprocessed before fed into tokenizer.
The preprocessing means:
The autoupdate feature is modified too, in order to monitor the main file and it's dependencies too.
The main goal was to get able splitting my stylesheets into smaller ones,
like collecting the colours used into one file, buttons into an other and so on.
Drawbacks:
could be slow if intensively used, however in this case we are checking
for 3 simple patterns.
however they aren’t used on NUI-level at all.