fix: code quality improvements from review #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused PaneState type from types and exports - Extract cn() utility for className combination (reduces duplication) - Add comprehensive tests for usePersistence hook (12 new tests) - Add SSR safety check to announce() function - Document Escape key in README keyboard navigation - Move Tailwind/shadcn section to separate TAILWIND.md file - Refactor useResizer to avoid state-during-render pattern (React 19 compatible) Closes #858 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses code quality improvements identified in a comprehensive code review.
Changes
PaneStatetype - Removed vestigial type that was never used in codebasecn()utility - Created reusable className combination utility to reduce duplication across components (SplitPane, Pane, Divider)usePersistencetests - Added 12 comprehensive tests for the persistence hook including error handling, debounce behavior, and key changesannounce()- Addedtypeof document !== 'undefined'check to prevent errors during server-side renderingTAILWIND.mdfile to reduce README sizeuseResizerto useuseEffectfor prop synchronization instead of setting state during renderTest Results
Test plan
npm run checks- all passcn()utility works correctly in all componentsannounce()functionusePersistencetests cover all edge casesCloses #858
🤖 Generated with Claude Code