fix: data field in DataTransferRequest objects is optional

[j-white]

the data field on the DataTransfer* messages is optional

unfortunately a breaking change 😀

[parberge]

Looks good to me, but I think @tommymalmqvist will have to review it as well.

[parberge]

the data field on the DataTransfer* messages is optional

unfortunately a breaking change 😀

Is it really a breaking change though? Since it should be backward compatible if I understand the code (which is likely that I don't 😄 ). But please let me know your thoughts here.

[codecov]

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.67%. Comparing base (95e628b) to head (dd71f4a).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/tests/schema_validation/v2_0_1.rs	80.95%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   81.68%   81.67%   -0.02%     
==========================================
  Files          51       51              
  Lines        4347     4366      +19     
==========================================
+ Hits         3551     3566      +15     
- Misses        796      800       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[parberge]

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.67%. Comparing base (1a6af0f) to head (47a288f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tests/schema_validation/v2_0_1.rs 80.95% 4 Missing ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

I don't know what's up with our test coverage. I suspect something is not working properly. Tried to fix it in #132 but I don't have enough technical skill to know what the problem is.

[j-white]

Is it really a breaking change though? Since it should be backward compatible if I understand the code (which is likely that I don't 😄 ). But please let me know your thoughts here.

If someone is already creating DataTransferRequest objects today, then this will break their code on upgrade. So safer to increment to major version for release.