Solution/m3-007 #27
Open
Solution/m3-007 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleattene
requested changes
Aug 26, 2024
|
|
||
| decompressedList.forEach( | ||
| (item) => (compressedArray[item] = (compressedArray[item] || 0) + 1) | ||
| ); // Recursive step |
There was a problem hiding this comment.
This is not a recursive step but a loop.
Review your implementation because it is incorrect. ;-)
| return compressedArray; | ||
| } | ||
|
|
||
| const decompressedList = [...prompt('Enter what you desire')].sort(); |
There was a problem hiding this comment.
What happens if you enter AAABBBAAA?
You get A:6, B:3 when you should get A, 3, B, 3, A, 3.
Theoretically, you should start with an array ... compress it (exe 006) and decompress it (exe 007) obtaining in the end the same starting array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questa funzione prende come parametro un array, i cui elementi sono stati ordinati in ordine crescente con il metodo sort(), per facilitare la lettura degli item compressati nel nuovo array.
Ho utilizzato il metodo forEach per mappare ogni singolo item dell'array, evitando di utilizzare il for loop.
Il caso base è rappresentato da un eventuale array vuoto, mentre il passo ricorsivo è il forEach() utilizzato per mappare l'array stesso e numerare gli item duplicati.