Solution/m3 final project #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First commit - Missing the delete object function
Second commit
Third commit
effedib
reviewed
Nov 11, 2024
projects/final-project/main.py
Outdated
| def main(): | ||
| print('HOUSEHOLD CATALOG MANAGER') | ||
| setHouseRooms() | ||
| Operation='' |
There was a problem hiding this comment.
Uppercase identifies classes in python, not variables
effedib
reviewed
Nov 11, 2024
projects/final-project/main.py
Outdated
| while not setHouseMode in ['1','2']: | ||
| setHouseMode=input('Wrong, input! Retry: ') | ||
| else: | ||
| SetHouseMode='2' |
There was a problem hiding this comment.
SetHouseMode or setHouseMode? Uppercase is only for classes but, more important, have you tested your code?
effedib
reviewed
Nov 11, 2024
projects/final-project/main.py
Outdated
| SetHouseMode='2' | ||
|
|
||
| #--PERFORMING INSERTION--# | ||
| if SetHouseMode=='1': |
There was a problem hiding this comment.
Where SetHouseMode is set equal to 1 in your code? It is possible set the variable to 1?
|
good work, this version is much better than previous! |
Fourth commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.