Improve Phoenix PubSub subscribe retries#191
Merged
Conversation
…fications module has successfully subscribed to the notifications topic.
…ore some operations, rather than sleeping. Also add a helper to assert with retries.
tompave
force-pushed
the
subscribe_behaviour
branch
from
c77c54b to
e6d06bd
Compare
…sub process in the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Elixir 1.18, the Phoenix PubSub tests had become very flaky locally. This was because the tests where running before the change notifications GenServer could fully subscribe to the notifications topic.
This PR fixes that with a new system to track the subscription status, plus new test helpers to assert with retries, rather than waiting for a timer.