Skip to content

Remove now unneeded test helper #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompave merged 1 commit into from
Feb 23, 2025
Merged

Remove now unneeded test helper #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions test/fun_with_flags/supervisor_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
defmodule FunWithFlags.SupervisorTest do
use FunWithFlags.TestCase, async: false
import FunWithFlags.TestUtils

alias FunWithFlags.Config

Expand Down Expand Up @@ -219,10 +218,6 @@ defmodule FunWithFlags.SupervisorTest do
end

defp expected_supervisor_spec do
if on_elixir_15?() do
%{intensity: 3, period: 5, strategy: :one_for_one, auto_shutdown: :never}
else
%{intensity: 3, period: 5, strategy: :one_for_one}
end
%{intensity: 3, period: 5, strategy: :one_for_one, auto_shutdown: :never}
end
end
4 changes: 0 additions & 4 deletions test/support/test_utils.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,6 @@ defmodule FunWithFlags.TestUtils do
configure_redis_with([database: 5])
end

def on_elixir_15? do
Version.match?(System.version, ">= 1.15.0")
end

def phx_pubsub_ready? do
try do
Process.whereis(FunWithFlags.Notifications.PhoenixPubSub) &&
Expand Down
Loading